Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated with-babel-macros example to utilize the app router. #73347

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the with-babel-macros example for using the App Router.
Here are the changes that have been made:

  • I renamed the pages folder and moved it to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 29, 2024
@ijjk
Copy link
Member

ijjk commented Nov 29, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2b72603

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/preval.macro@5.0.0 Transitive: filesystem +1 43.5 kB kentcdodds

🚮 Removed packages: npm/preval.macro@3.0.0

View full report↗︎

@PapatMayuri PapatMayuri marked this pull request as ready for review November 29, 2024 14:14
@samcx samcx self-requested a review November 29, 2024 21:06
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) November 29, 2024 21:17
@samcx samcx merged commit 803dca3 into vercel:canary Nov 29, 2024
39 checks passed
samcx added a commit that referenced this pull request Dec 10, 2024
## Description

Follow up #73347.
Sync the app router file structure.

CC: @samcx 

### Adding or Updating Examples

- [x] The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- [x] Make sure the linting passes by running `pnpm build && pnpm lint`.
See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

Co-authored-by: Sam Ko <sam@vercel.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants